…v#9519)

## Description

`Workspace::initial_vertical_tabs_panel_open`
(`app/src/workspace/view.rs:3726`) honored the persisted
`window_snapshot.vertical_tabs_panel_open` value unconditionally when
vertical tabs were not usable in the current workspace. If a user
previously had vertical tabs enabled with the panel open, then later set
`appearance.vertical_tabs.enabled = false`, restoring the workspace
booted with `vertical_tabs_panel_open = true` while the panel itself
never rendered (rendering is gated on `should_default_open`).

The panel didn't render — but its `Dismiss` underlay did. The underlay's
`prevent_interaction_with_other_elements` swallowed every click while
hover and keyboard input still worked, leaving the window visually
responsive but functionally dead. The repeated
`workspace_view:vertical_tabs_panel` position-cache warnings and
`Dismiss underlay was clicked but no handler was set!` log lines
reported in the issue come from this state.

### Fix

When `should_default_open` is `false` (feature flag off OR
`use_vertical_tabs = false`), return `false` from
`initial_vertical_tabs_panel_open` instead of falling through to the
persisted snapshot.

```rust
// before
if should_default_open && *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open  // restores stale `true` even when disabled
}

// after
if !should_default_open {
    false  // <-- new
} else if *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open
}
```

Unrelated existing arms (`Empty`, `FromTemplate`, `TransferredTab`,
etc.) already returned `should_default_open` directly so they were never
affected — the bug was specific to the `Restored` branch.

## Testing

Adds
`test_vertical_tabs_panel_closed_when_disabled_even_if_persisted_open`
in `app/src/workspace/view_test.rs`, which reproduces the exact upgrade
sequence from the issue:

1. Enable vertical tabs (feature flag + setting), open the panel,
snapshot the workspace.
2. Disable the `use_vertical_tabs` setting.
3. Restore from the open-panel snapshot.
4. Assert `workspace.vertical_tabs_panel_open == false`.

Without the fix this test fails — the workspace boots with
`vertical_tabs_panel_open == true` and the click-eating dismiss underlay
would paint at runtime.

The existing tests
`test_vertical_tabs_panel_visibility_restores_from_window_snapshot` and
`test_vertical_tabs_panel_restored_open_when_show_in_restored_windows_enabled`
both keep `use_vertical_tabs = true`, so they exercise the unchanged
`else` branches and continue to pass.

**Local presubmit note:** `cargo fmt --check` passes locally. Full
`./script/presubmit` is blocked by Metal Toolchain activation on this
machine (downloaded asset not yet active); CI will run the full
clippy/nextest matrix.

## Server API dependencies

This PR does not depend on any server API changes.

## Agent Mode
- [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

## Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fix Warp window becoming unclickable on Linux/Wayland
after upgrading with a persisted vertical-tabs panel state — restoring
no longer leaves a stale dismiss underlay above the window when vertical
tabs are disabled.

Fixes warpdotdev#9505

Co-authored-by: zachbai <zachrybai@gmail.com>
Co-authored-by: Oz <oz-agent@warp.dev>

…v#9519)

## Description

`Workspace::initial_vertical_tabs_panel_open`
(`app/src/workspace/view.rs:3726`) honored the persisted
`window_snapshot.vertical_tabs_panel_open` value unconditionally when
vertical tabs were not usable in the current workspace. If a user
previously had vertical tabs enabled with the panel open, then later set
`appearance.vertical_tabs.enabled = false`, restoring the workspace
booted with `vertical_tabs_panel_open = true` while the panel itself
never rendered (rendering is gated on `should_default_open`).

The panel didn't render — but its `Dismiss` underlay did. The underlay's
`prevent_interaction_with_other_elements` swallowed every click while
hover and keyboard input still worked, leaving the window visually
responsive but functionally dead. The repeated
`workspace_view:vertical_tabs_panel` position-cache warnings and
`Dismiss underlay was clicked but no handler was set!` log lines
reported in the issue come from this state.

### Fix

When `should_default_open` is `false` (feature flag off OR
`use_vertical_tabs = false`), return `false` from
`initial_vertical_tabs_panel_open` instead of falling through to the
persisted snapshot.

```rust
// before
if should_default_open && *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open  // restores stale `true` even when disabled
}

// after
if !should_default_open {
    false  // <-- new
} else if *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open
}
```

Unrelated existing arms (`Empty`, `FromTemplate`, `TransferredTab`,
etc.) already returned `should_default_open` directly so they were never
affected — the bug was specific to the `Restored` branch.

## Testing

Adds
`test_vertical_tabs_panel_closed_when_disabled_even_if_persisted_open`
in `app/src/workspace/view_test.rs`, which reproduces the exact upgrade
sequence from the issue:

1. Enable vertical tabs (feature flag + setting), open the panel,
snapshot the workspace.
2. Disable the `use_vertical_tabs` setting.
3. Restore from the open-panel snapshot.
4. Assert `workspace.vertical_tabs_panel_open == false`.

Without the fix this test fails — the workspace boots with
`vertical_tabs_panel_open == true` and the click-eating dismiss underlay
would paint at runtime.

The existing tests
`test_vertical_tabs_panel_visibility_restores_from_window_snapshot` and
`test_vertical_tabs_panel_restored_open_when_show_in_restored_windows_enabled`
both keep `use_vertical_tabs = true`, so they exercise the unchanged
`else` branches and continue to pass.

**Local presubmit note:** `cargo fmt --check` passes locally. Full
`./script/presubmit` is blocked by Metal Toolchain activation on this
machine (downloaded asset not yet active); CI will run the full
clippy/nextest matrix.

## Server API dependencies

This PR does not depend on any server API changes.

## Agent Mode
- [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

## Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fix Warp window becoming unclickable on Linux/Wayland
after upgrading with a persisted vertical-tabs panel state — restoring
no longer leaves a stale dismiss underlay above the window when vertical
tabs are disabled.

Fixes warpdotdev#9505

Co-authored-by: zachbai <zachrybai@gmail.com>
Co-authored-by: Oz <oz-agent@warp.dev>
(cherry picked from commit 3aac007)

…v#9519)

## Description

`Workspace::initial_vertical_tabs_panel_open`
(`app/src/workspace/view.rs:3726`) honored the persisted
`window_snapshot.vertical_tabs_panel_open` value unconditionally when
vertical tabs were not usable in the current workspace. If a user
previously had vertical tabs enabled with the panel open, then later set
`appearance.vertical_tabs.enabled = false`, restoring the workspace
booted with `vertical_tabs_panel_open = true` while the panel itself
never rendered (rendering is gated on `should_default_open`).

The panel didn't render — but its `Dismiss` underlay did. The underlay's
`prevent_interaction_with_other_elements` swallowed every click while
hover and keyboard input still worked, leaving the window visually
responsive but functionally dead. The repeated
`workspace_view:vertical_tabs_panel` position-cache warnings and
`Dismiss underlay was clicked but no handler was set!` log lines
reported in the issue come from this state.

### Fix

When `should_default_open` is `false` (feature flag off OR
`use_vertical_tabs = false`), return `false` from
`initial_vertical_tabs_panel_open` instead of falling through to the
persisted snapshot.

```rust
// before
if should_default_open && *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open  // restores stale `true` even when disabled
}

// after
if !should_default_open {
    false  // <-- new
} else if *show_vertical_tab_panel_in_restored_windows {
    true
} else {
    window_snapshot.vertical_tabs_panel_open
}
```

Unrelated existing arms (`Empty`, `FromTemplate`, `TransferredTab`,
etc.) already returned `should_default_open` directly so they were never
affected — the bug was specific to the `Restored` branch.

## Testing

Adds
`test_vertical_tabs_panel_closed_when_disabled_even_if_persisted_open`
in `app/src/workspace/view_test.rs`, which reproduces the exact upgrade
sequence from the issue:

1. Enable vertical tabs (feature flag + setting), open the panel,
snapshot the workspace.
2. Disable the `use_vertical_tabs` setting.
3. Restore from the open-panel snapshot.
4. Assert `workspace.vertical_tabs_panel_open == false`.

Without the fix this test fails — the workspace boots with
`vertical_tabs_panel_open == true` and the click-eating dismiss underlay
would paint at runtime.

The existing tests
`test_vertical_tabs_panel_visibility_restores_from_window_snapshot` and
`test_vertical_tabs_panel_restored_open_when_show_in_restored_windows_enabled`
both keep `use_vertical_tabs = true`, so they exercise the unchanged
`else` branches and continue to pass.

**Local presubmit note:** `cargo fmt --check` passes locally. Full
`./script/presubmit` is blocked by Metal Toolchain activation on this
machine (downloaded asset not yet active); CI will run the full
clippy/nextest matrix.

## Server API dependencies

This PR does not depend on any server API changes.

## Agent Mode
- [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

## Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fix Warp window becoming unclickable on Linux/Wayland
after upgrading with a persisted vertical-tabs panel state — restoring
no longer leaves a stale dismiss underlay above the window when vertical
tabs are disabled.

Fixes warpdotdev#9505

Co-authored-by: zachbai <zachrybai@gmail.com>
Co-authored-by: Oz <oz-agent@warp.dev>